tools: remove eslint rule no-let-in-for-declaration #26715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
requested changes
Mar 17, 2019
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Please also remove
Line 20 in 32853c0
gengjiawen
force-pushed
the
remove_no_let_rule
branch
from
51768bc to
8da5542
Compare
Member
Author
Fixed. |
richardlau
approved these changes
Mar 17, 2019
Member
|
I'm happy for this to land before Node.js 6 goes End-of-Life at the end of April as #26684 is the last planned release and nothing is landing there without a good deal of caution. |
Member
Author
I am happy that we can use native async await in community libs as node 6 reaches EOL :) |
targos
approved these changes
Mar 17, 2019
ZYSzys
approved these changes
Mar 17, 2019
BridgeAR
approved these changes
Mar 19, 2019
Contributor
BridgeAR
added
the
author ready
Collaborator
Member
Author
|
@danbev Can you import this ? Thanks. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Mar 26, 2019
PR-URL: nodejs#26715 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 8209cae |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26715 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26715 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continue our discussion in #26562 (comment)
cc @targos @ZYSzys @Trott @BridgeAR
Maybe still add a label
don't land on 6.xthough the last 6.x release has been drafted.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes