Skip to content

[v11.x backport] http: send connection: close when closing conn #26646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[v11.x backport] http: send connection: close when closing conn #26646

wants to merge 0 commits into from

Conversation

@johanneswuerbach
Copy link

@johanneswuerbach johanneswuerbach commented Mar 13, 2019

Back-port of #26467 to v11

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v11.x labels Mar 13, 2019
This was referenced Mar 13, 2019
Closed
Closed
@lpinca
Copy link
Member

lpinca commented Mar 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21534/

@BridgeAR
Copy link
Member

BridgeAR commented Mar 14, 2019

@johanneswuerbach thanks a lot for the backport! I landed it on v11.x-staging.

@BridgeAR BridgeAR closed this Mar 14, 2019
@johanneswuerbach johanneswuerbach deleted the backport-26467-11 branch March 14, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johanneswuerbach @lpinca @BridgeAR @nodejs-github-bot