http: use internal/debuglog directly in lib/_http_agent.js #26567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Mar 10, 2019
BridgeAR
changed the title
|
@micheleriva thanks for your PR! Please have another look at the commit guidelines again. |
|
@micheleriva Can you checkout the commit guidelines and rewrite the commit message? BTW, please remove the |
|
@joyeecheung we can fix the commit message while landing. |
BridgeAR
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22196/ ✅ (besides Windows) |
|
@micheleriva I am very sorry but it seems like this change has already landed in Node.js else wise. Thanks a lot for your contribution and keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces internal usage of public require('util').
Single PR as asked here: #26546 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes