Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add no-var lint rule for tools directory #26398

Closed
wants to merge 2 commits into from
Closed

tools: add no-var lint rule for tools directory #26398

wants to merge 2 commits into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Mar 2, 2019

  • first commit is that var is replaced to let/const.
  • second commit is that no-var rule is added to tools/.eslintrc.yaml.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@shisama build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2743/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 2, 2019
@ChALkeR
Copy link
Member

ChALkeR commented Mar 2, 2019

How many errors does prefer-const give?

@refack
Copy link
Contributor

refack commented Mar 2, 2019 •
edited
Loading

How many errors does prefer-const give?

🍩

P.S. it's because it's already active from parent scope

node/.eslintrc.js

Line 249 in b1ef279

'prefer-const': ['error', { ignoreReadBeforeAssign: true }],

@shisama
Copy link
Contributor Author

shisama commented Mar 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21158/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 3, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

@shisama this requires a rebase.

@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@shisama
Copy link
Contributor Author

shisama commented Mar 6, 2019

rebase build: https://ci.nodejs.org/job/node-test-pull-request/21246/

@shisama
Copy link
Contributor Author

shisama commented Mar 6, 2019

@BridgeAR rebased this. Thank you.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
@BridgeAR
tools: replace var to let/const
ce8f01c 
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
@BridgeAR
tools: add no-var lint rule for tools directory
70beb76 
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Landed in ce8f01c, 70beb76 🎉

@BridgeAR BridgeAR closed this Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@BridgeAR
tools: replace var to let/const
b3ecaaa 
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@BridgeAR
tools: add no-var lint rule for tools directory
a8331fa 
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@BridgeAR
tools: replace var to let/const
57198f2 
PR-URL: #26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@BridgeAR
tools: add no-var lint rule for tools directory
0a1537e 
PR-URL: #26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@shisama shisama deleted the no-var-for-tools branch March 21, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shisama @nodejs-github-bot @ChALkeR @refack @BridgeAR @cjihrig @gengjiawen @richardlau