Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: added example for setting Vary: Accept-Encoding header in zlib.md #26308

Closed
wants to merge 3 commits into from
Closed

doc: added example for setting Vary: Accept-Encoding header in zlib.md #26308

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d510b68
doc: added example for setting Vary: Accept-Encoding header in zlib.md
mukulkhanna Feb 26, 2019
83335ea
docs: adhere to linting rules
mukulkhanna Feb 26, 2019
2b7f394
Fixes: https://github.com/nodejs/node/issues/25495
Trott Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/api/zlib.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ const http = require('http');
const fs = require('fs');
http.createServer((request, response) => {
const raw = fs.createReadStream('index.html');
// instruct the proxy to store both a compressed and uncompressed version of the resource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @mukulkhanna! Welcome and thanks for the pull request! This line above is (probably) going to cause the linter to complain. Could you wrap the comment at 80 characters and capitalize the first letter of the first word? (Might as well put a period/full-stop at the end while you're at it.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and you can check the linting with make lint (or vcbuild lint on Windows).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Trott.
Sure, will do asap, thank you.

response.setHeader('Vary: Accept-Encoding');
let acceptEncoding = request.headers['accept-encoding'];
if (!acceptEncoding) {
acceptEncoding = '';
Expand Down