Skip to content

lib: end-of-life the deprecated require('sys') #26292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

lib: end-of-life the deprecated require('sys') #26292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ module.exports = {
'no-path-concat': 'error',
'no-proto': 'error',
'no-redeclare': 'error',
'no-restricted-modules': ['error', 'sys'],
'no-restricted-modules': ['error'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'no-restricted-modules': ['error'],
'no-restricted-modules': 'error',

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be deleted entirely. If you don't specify a second argument, the rule does nothing.

/* eslint-disable max-len */
'no-restricted-properties': [
'error',
Expand Down
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,9 @@ The `REPLServer.prototype.convertToContext()` API has been removed.
### DEP0025: require('sys')
<!-- YAML
changes:
- version: REPLACEME
pr-url: XXX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pr-url: XXX
pr-url: https://github.com/nodejs/node/pull/26292

description: End-of-Life.
- version:
- v4.8.6
- v6.12.0
Expand All @@ -561,7 +564,7 @@ changes:
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `sys` module is deprecated. Please use the [`util`][] module instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

Suggested change
The `sys` module is deprecated. Please use the [`util`][] module instead.
The `sys` module was removed. Please use the [`util`][] module instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not sure where the leading space emerges from)


Expand Down
1 change: 0 additions & 1 deletion lib/internal/bootstrap/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const { hasTracing, hasInspector } = internalBinding('config');
// Modules with source code compiled in js2c that
// cannot be compiled with the code cache.
const cannotBeRequired = [
'sys', // Deprecated.
'internal/v8_prof_polyfill',
'internal/v8_prof_processor',

Expand Down
30 changes: 0 additions & 30 deletions lib/sys.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
'lib/_stream_passthrough.js',
'lib/_stream_wrap.js',
'lib/string_decoder.js',
'lib/sys.js',
'lib/timers.js',
'lib/tls.js',
'lib/_tls_common.js',
Expand Down