Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: convert legacy process.binding to internalBinding #26095

Closed
wants to merge 1 commit into from
Closed

lib: convert legacy process.binding to internalBinding #26095

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Feb 14, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2019
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20838/

@addaleax
Copy link
Member

addaleax commented Feb 17, 2019 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20844/ (:heavy_check_mark:)

@danbev
Copy link
Contributor

danbev commented Feb 18, 2019

Landed in 04c839b.

@danbev danbev closed this Feb 18, 2019
danbev pushed a commit that referenced this pull request Feb 18, 2019
@ZYSzys @danbev
lib: convert legacy process.binding to internalBinding
04c839b 
PR-URL: #26095
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 18, 2019
@ZYSzys @addaleax
lib: convert legacy process.binding to internalBinding
03506d7 
PR-URL: #26095
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@ZYSzys @rvagg
lib: convert legacy process.binding to internalBinding
733beb7 
PR-URL: #26095
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ZYSzys ZYSzys deleted the use-internalbinding branch March 2, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZYSzys @addaleax @danbev @jasnell @cjihrig @joyeecheung @devsnek