Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm: fix esm load bug #25491

Closed
wants to merge 3 commits into from
+16 −3
Closed

esm: fix esm load bug #25491

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85891a0
esm: fix esm load bug
ZYSzys May 13, 2019
243600a
test: clearing require cache crashes esm loader
aduh95 May 2, 2019
72bdf65
fixup! esm: fix esm load bug
ZYSzys May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: clearing require cache crashes esm loader 
This test shows the regression introduced in v11.4.0: clearing out the
require.cache crashes node when using the `--experimental-modules` flag.
Refs: #25482
  • Loading branch information
@aduh95 @ZYSzys
aduh95 authored and ZYSzys committed May 13, 2019
commit 243600a5c3896a868bf8294d241baccc38ee7263
11 changes: 11 additions & 0 deletions test/known_issues/test-esm-loader-cache-clearing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Flags: --experimental-modules
'use strict';
require('../common');

const { cache } = require;

Object.keys(cache).forEach((key) => {
delete cache[key];
});
// Require the same module again triggers the crash
require('../common');