Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: reorganize process object creation, property implementation and events in C++ land #25397

Closed
wants to merge 7 commits into from
Closed

src: reorganize process object creation, property implementation and events in C++ land #25397

wants to merge 7 commits into from

Commits on Jan 9, 2019

  1. src: move process object creation into node_process_object.cc 

    Changes `SetupProcessObject` to `CreateProessObject` which creates
the process object from scratch and return it to `Environment::Start`
to be stored in the Environment object.
    @joyeecheung
    joyeecheung committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    60d3a5e View commit details
    Browse the repository at this point in the history

  2. src: declare process-related C++ methods in node_process.h 

    Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.
    @joyeecheung
    joyeecheung committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    a28145b View commit details
    Browse the repository at this point in the history

  3. process: move C++ process events into node_process_events.cc 

    Move the C++ `process.emit` and `process.emitWarning` methods
from `node.cc` into into `node_process_events.cc`, and
reuse the implementation in other places that need to do
`process.emit` in C++.
    @joyeecheung
    joyeecheung committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    5e1b8a2 View commit details
    Browse the repository at this point in the history

  4. fixup! src: move process object creation into node_process_object.cc

    @joyeecheung
    joyeecheung committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    ff4e9de View commit details
    Browse the repository at this point in the history

  5. fixup! src: declare process-related C++ methods in node_process.h

    @joyeecheung
    joyeecheung committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    cc8d7e3 View commit details
    Browse the repository at this point in the history

  6. fixup! src: move process object creation into node_process_object.cc

    @joyeecheung
    joyeecheung committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    cdd42e7 View commit details
    Browse the repository at this point in the history

  7. fixup! process: move C++ process events into node_process_events.cc

    @joyeecheung
    joyeecheung committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    b05ae4e View commit details
    Browse the repository at this point in the history