Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CSI (\x9b) as additionally allowable escape #2521

Closed
wants to merge 1 commit into from
Closed

added CSI (\x9b) as additionally allowable escape #2521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added CSI (\x9b) as additionally allowable escape 
Added `\x9b` as an additionally allowable ANSI escape code. It's pretty phased out, but can still be used.

The difference between the two is that `\x1b` requires a following `[`. Together, both of those characters combined form the CSI. There is the single character alternative, `\x9b`, that doesn't require the `[`. It is less common, I speculate, because faulty ANSI implementations will output `[37;1m` which is more distinct than just `37;1m` - don't quote me on that though. All I know is that it has to do with [C0 and C1 control codes](https://en.wikipedia.org/wiki/C0_and_C1_control_codes) and a bunch of unicode voodoo.

I doubt many terminal emulators even support it nowadays but it *is* something you should probably be checking for.
  • Loading branch information
@Qix-
Qix- committed Aug 24, 2015
commit 4bb27d7389d1701ab6f93f0fed7020d40de9f4b8
11 changes: 6 additions & 5 deletions lib/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,8 +973,9 @@ exports.emitKeypressEvents = emitKeypressEvents;
*/

// Regexes used for ansi escape code splitting
const metaKeyCodeReAnywhere = /(?:\x1b)([a-zA-Z0-9])/;
const functionKeyCodeReAnywhere = new RegExp('(?:\x1b+)(O|N|\\[|\\[\\[)(?:' + [
const metaKeyCodeReAnywhere = /(?:(?:\x1b|\x9b))([a-zA-Z0-9])/;
const functionKeyCodeReAnywhere = new RegExp('(?:(?:\x1b|\x9b)+)' +
'(O|N|\\[|\\[\\[)(?:' + [
'(\\d+)(?:;(\\d+))?([~^$])',
'(?:M([@ #!a`])(.)(.))', // mouse
'(?:1;)?(\\d+)?([a-zA-Z])'
Expand All @@ -994,11 +995,11 @@ function* emitKeys(stream) {
shift: false
};

if (ch === '\x1b') {
if (ch === '\x1b' || ch === '\x9b') {
escaped = true;
s += (ch = yield);

if (ch === '\x1b') {
if (ch === '\x1b' || ch === '\x9b') {
s += (ch = yield);
}
}
Expand Down Expand Up @@ -1219,7 +1220,7 @@ function* emitKeys(stream) {
key.name = 'backspace';
key.meta = escaped;

} else if (ch === '\x1b') {
} else if (ch === '\x1b' || ch === '\x9b') {
// escape key
key.name = 'escape';
key.meta = escaped;
Expand Down