Closed
Conversation
This simplifies the `format()` code and significantly improves the performance.
Member
Author
|
@nodejs/performance @nodejs/util PTAL |
devsnek
approved these changes
Dec 12, 2018
Fishrock123
approved these changes
Dec 13, 2018
silverwind
approved these changes
Dec 13, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Dec 14, 2018
This simplifies the `format()` code and significantly improves the performance. PR-URL: nodejs#24981 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Member
Author
|
Landed in 9752fce |
Contributor
|
This does not land cleanly on v11.x, would someone be willing to backport? |
Contributor
|
I don't think it's worth backporting as the performance regression was mostly introduced by my |
Member
Author
|
I changed the labels so this is not requested for backporting anymore. |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This simplifies the `format()` code and significantly improves the performance. PR-URL: nodejs#24981 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the
format()code and significantly improves theperformance.
Just a few runs to verify the gain:
CI https://ci.nodejs.org/job/node-test-pull-request/19442/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes