src: use isolate version of BooleanValue()#24883
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
src: use isolate version of BooleanValue()#24883cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
This fixes deprecation warnings.
nodejs-github-bot
added
c++
targos
approved these changes
Dec 7, 2018
danbev
approved these changes
Dec 7, 2018
joyeecheung
approved these changes
Dec 7, 2018
addaleax
approved these changes
Dec 7, 2018
Member
Trott
added
the
author ready
Member
|
Landed in 24e6b70 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 9, 2018
This fixes deprecation warnings. PR-URL: nodejs#24883 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
This landed cleanly on v11.x-staging, but caused some compile errors - does it need a backport? |
Contributor
|
The Isolate version of BooleanValue only exists on master, using an API from v8 7.1.302.28, so unless v8 gets updated on 11.x this change can't backport. |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This fixes deprecation warnings. PR-URL: nodejs#24883 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes deprecation warnings.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes