test: adding history regression test case #24843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antsmartian sadly an error occured when I tried to trigger a build :( |
BridgeAR
reviewed
Dec 5, 2018
antsmartian
force-pushed
the
repl-history-test-case
branch
from
912aa88
to
078dfa8
Compare
|
Rebuild CI Lite : https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1862/ |
|
@BridgeAR ping... |
|
@nodejs/repl @BridgeAR Gentle remainder 🔉 |
BridgeAR
approved these changes
Dec 12, 2018
| }, | ||
| { | ||
| env: {}, | ||
| test: [UP, UP, UP, DOWN, DOWN, DOWN], |
There was a problem hiding this comment.
I suggest to add one more UP and one more DOWN so we reach the end of the list in both cases.
There was a problem hiding this comment.
Yeah, taken care of this. Guess should be good now.. cc @BridgeAR
antsmartian
force-pushed
the
repl-history-test-case
branch
from
078dfa8
to
9d7ce13
Compare
|
@BridgeAR Can you please just have a look now, have addressed your comments and I wanted to take your review once before I land this to master. |
|
Still LG but please run a regular CI |
|
Yeah sure, thanks much @BridgeAR. |
|
Landed in 0bf7d41 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Thanks @Trott |
Merged
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Dec 24, 2018
PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently added mulitline caused a issue in history navigation ref: #24385
Fundamentally, we don't had a test case for navigation till now, the one I see here: https://github.com/nodejs/node/blob/master/test/parallel/test-repl-persistent-history.js#L97, just tests one level navigation.
cc @nodejs/repl @BridgeAR
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes