Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: improve internal isError() validation #24746

Closed
wants to merge 5 commits into from
Closed

util: improve internal isError() validation #24746

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab135e7
util: improve internal `isError()` validation
BridgeAR Nov 18, 2018
9009e4c
fixup: add test case
BridgeAR Nov 30, 2018
434eb41
fixup: add further test case
BridgeAR Dec 2, 2018
d346011
fixup: more verbose comment
BridgeAR Dec 2, 2018
ddc82e4
fixup: add test explanation
BridgeAR Dec 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: add test case
  • Loading branch information
@BridgeAR
BridgeAR committed Nov 30, 2018
commit 9009e4c3dac037325faaec40af05e029cd95ecd6
25 changes: 25 additions & 0 deletions test/parallel/test-internal-util-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Flags: --expose-internals
'use strict';

require('../common');
const assert = require('assert');
const { types } = require('util');
const { isError } = require('internal/util');
BridgeAR marked this conversation as resolved.
Show resolved Hide resolved

// Special cased errors.
{
const fake = { [Symbol.toStringTag]: 'Error' };
assert(!types.isNativeError(fake));
assert(!(fake instanceof Error));
assert(!isError(fake));

const err = new Error('test');
const newErr = Object.create(
Object.getPrototypeOf(err),
Object.getOwnPropertyDescriptors(err));
Object.defineProperty(err, 'message', { value: err.message });
assert(types.isNativeError(err));
assert(!types.isNativeError(newErr));
assert(newErr instanceof Error);
assert(isError(newErr));
}