-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test and docs update for detached fork process #24524
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: test and docs for detached fork process
This tests child process fork component in detached mode by spawning a parent process that creates a child process. We kill the parent process and check if the child is still running. Fixes: #17592
- Loading branch information
commit f1f4837b52c4eb14c17f6ac6bae010f92f4ccfd8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
const fork = require('child_process').fork; | ||
const path = require('path'); | ||
|
||
const child = fork( | ||
path.join(__dirname, 'child-process-persistent.js'), | ||
[], | ||
{ detached: true, stdio: 'ignore' } | ||
); | ||
|
||
console.log(child.pid); | ||
|
||
child.unref(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
const fork = require('child_process').fork; | ||
const fixtures = require('../common/fixtures'); | ||
|
||
const nonPersistentNode = fork( | ||
fixtures.path('parent-process-nonpersistent-fork.js'), | ||
[], | ||
{ silent: true }); | ||
|
||
let childId = -1; | ||
|
||
nonPersistentNode.stdout.on('data', (data) => { | ||
childId = parseInt(data, 10); | ||
nonPersistentNode.kill(); | ||
}); | ||
|
||
process.on('exit', () => { | ||
assert.notStrictEqual(childId, -1); | ||
// Killing the child process should not throw an error | ||
process.kill(childId); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This strikes me as having significant potential for leaving stray processes around on CI. Not necessarily blocking, but surely something to keep an eye on after this lands....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I totally agree. One of my checks was to make sure that no node processes were running after I ran the test individually.