Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: elevate v8 namespaces of node_trace_events.cc #24469

Closed
wants to merge 7 commits into from
Closed

src: elevate v8 namespaces of node_trace_events.cc #24469

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
79d678f
test:replace anonymous closure function
Jayasankar-m Nov 17, 2018
4a88789
Merge branch 'master' of https://github.com/nodejs/node
Jayasankar-m Nov 17, 2018
297b5d3
Merge branch 'master' of https://github.com/nodejs/node
Jayasankar-m Nov 19, 2018
98d3a5d
src: elevate v8 namespaces of node_trace_events.cc
Jayasankar-m Nov 19, 2018
4f601e6
src: elevate v8 namespaces of node_trace_events.cc
Jayasankar-m Nov 19, 2018
7b47021
Merge branch 'master' of https://github.com/nodejs/node into v8scope
Jayasankar-m Nov 19, 2018
01d6d37
src: elevate v8 namespaces of node_trace_events.cc
Jayasankar-m Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/node_trace_events.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ using v8::Context;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
using v8::Local;
using v8::NewStringType;
using v8::Object;
using v8::String;
using v8::Value;


Jayasankar-m marked this conversation as resolved.
Show resolved Hide resolved
class NodeCategorySet : public BaseObject {
public:
static void New(const FunctionCallbackInfo<Value>& args);
Expand Down Expand Up @@ -91,7 +93,7 @@ void GetEnabledCategories(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(
String::NewFromUtf8(env->isolate(),
categories.c_str(),
v8::NewStringType::kNormal,
NewStringType::kNormal,
categories.size()).ToLocalChecked());
}
}
Expand Down