Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix - invalid timer priority queue order #24318

Closed
wants to merge 2 commits into from
Closed

lib: fix - invalid timer priority queue order #24318

wants to merge 2 commits into from

Commits on Nov 12, 2018

  1. lib: fix - invalid timer priority queue order 

    - in lib/timers.js PriorityQueue.percolateDown cannot be used for rescheduling list,
  because it does not work in all cases
  - updated item does not have to be root of the heap when new timers are created
    in runNextTicks and then percolateDown does not solve all binary heap
    inconsistencies
  - old behavior could cause infinite loop timers in some cases

- added PriorityQueue.updateAt and PriorityQueue.update methods
  - simple implementation by remove & insert, could be improved...
  - rescheduling list uses updateAt method
    @mareksrom
    mareksrom committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    fa558e6 View commit details
    Browse the repository at this point in the history

  2. lib: fix test build inconsistencies

    @mareksrom
    mareksrom committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    04f408b View commit details
    Browse the repository at this point in the history