Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,win: make installer res files ready for translation #24239

Closed
wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 7, 2018

Fixes: #819

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Nov 7, 2018
@refack
Copy link
Contributor Author

refack commented Nov 7, 2018

We just added a bunch of strings, they need translation.
BTW: I have no idea the winproj change works, and what is the output (multiple file, or one multicultural file).

/CC @nodejs/i18n @fhemberger

@refack refack added i18n-api Issues and PRs related to the i18n implementation. wip Issues and PRs that are still a work in progress. labels Nov 7, 2018
@fhemberger
Copy link
Contributor

@nodejs/i18n Could we hook up the installer files to the same translation process as the docs?

@fhemberger
Copy link
Contributor

Or the more general question would be: Do we want a translated installer at all?

The initial translation efforts are almost four years old, IIRC the Mac version never landed at all. It was such a long and tedious process with several PR revisions, also a lack of feedback from folks who worked on the initial installers. In the end I lost track and it discouraged me from contributing further.

Now seeing that the changes which were supposed to land after $ImportantRelease never made it in at all, I don't know …

@refack
Copy link
Contributor Author

refack commented Nov 8, 2018

Or the more general question would be: Do we want a translated installer at all?

Very valid question! If we don't have an i18n support team, this will break. Also AFAIK the current repertoire of translations is indicative of the Collaborators not of the users (no Spanish, Portugese, Hindi or Bengali)

@Trott
Copy link
Member

Trott commented Nov 20, 2018

@nodejs/community-committee Any chance you can help get translations here?

@Trott Trott added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Nov 20, 2018
@refack refack closed this Dec 21, 2018
@refack refack deleted the make-multi-culture-msi branch December 21, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. i18n-api Issues and PRs related to the i18n implementation. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate installers for OS X and Windows
4 participants