Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: describe what tls servername is for #24236

Closed

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Nov 7, 2018

Docs should describe the purpose of the option.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Nov 7, 2018
Docs should describe the purpose of the option.
@sam-github sam-github force-pushed the describe-what-servername-is-for branch from 07062de to bc9be3a Compare November 9, 2018 18:42
@sam-github
Copy link
Contributor Author

@sam-github
Copy link
Contributor Author

Landed in 27cdb36

sam-github added a commit that referenced this pull request Nov 10, 2018
Docs should describe the purpose of the option.

PR-URL: #24236
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@sam-github sam-github closed this Nov 10, 2018
@sam-github sam-github deleted the describe-what-servername-is-for branch November 10, 2018 00:24
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
Docs should describe the purpose of the option.

PR-URL: #24236
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Docs should describe the purpose of the option.

PR-URL: nodejs#24236
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Dec 14, 2018
Docs should describe the purpose of the option.

PR-URL: #24236
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
Docs should describe the purpose of the option.

PR-URL: #24236
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants