Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace pushValueToArray with pure C++ API #24125

Closed
wants to merge 4 commits into from
Closed

src: replace pushValueToArray with pure C++ API #24125

wants to merge 4 commits into from

Commits on Nov 6, 2018

  1. deps: cherry-pick 0483e9a from upstream V8 

    Original commit message:

    [api] Allow embedder to construct an Array from Local<Value>*

    Currently to obtain a v8::Array out of a C array or a std::vector,
    one needs to loop through the elements and call array->Set() multiple
    times, and these calls go into v8::Object::Set() which can be slow.
    This patch adds a new Array::New overload that converts a
    Local<Value>* with known size into a Local<Array>.

    Change-Id: I0a768f0e18eec51e78d58be455482ec6425ca188
    Reviewed-on: https://chromium-review.googlesource.com/c/1317049
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#57261}

Refs: v8/v8@0483e9a
    @joyeecheung
    joyeecheung committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    d1fdd28 View commit details
    Browse the repository at this point in the history

  2. fs: replace pushValueToArray with pure C++ API 

    Instead of calling into JS from C++ to push values into an array,
use the new Array::New API that takes a pointer and a length
directly.
    @joyeecheung
    joyeecheung committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    e02f5a6 View commit details
    Browse the repository at this point in the history

  3. benchmark: add dir and withFileTypes option readdir benchmarks

    @joyeecheung
    joyeecheung committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    72c6b4b View commit details
    Browse the repository at this point in the history

  4. fixup! benchmark: add dir and withFileTypes option readdir benchmarks

    @joyeecheung
    joyeecheung committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    beb263d View commit details
    Browse the repository at this point in the history