Skip to content

tools: fix c++ code coverage on macOS #24004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

tools: fix c++ code coverage on macOS #24004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/gyp/pylib/gyp/xcode_emulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,8 @@ def GetLibtoolflags(self, configname):
libtoolflags = []

for libtoolflag in self._Settings().get('OTHER_LDFLAGS', []):
if libtoolflag == "--coverage":
Copy link
Contributor

@refack refack Oct 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok after some digging is seem like the native libtool does not accept any flag that starts with --
Can I suggest this instead of the whole for expression (From L948 to L955)

    self.configname = configname
    libtoolflags = self._Settings().get('OTHER_LDFLAGS', [])
    # Native macOS libtool does not except any flags with '--' prefix
    libtoolflags = [f for f in libtoolflags if not f.startswith('--')]
    # TODO(thakis): ARCHS?

continue
libtoolflags.append(libtoolflag)
# TODO(thakis): ARCHS?

Expand Down