Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix strictEqual() arguments order #23800

Closed
wants to merge 1 commit into from
Closed

test: fix strictEqual() arguments order #23800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions test/parallel/test-http-upgrade-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,20 +98,20 @@ function test_upgrade_with_listener() {
conn.on('data', function(data) {
state++;

assert.strictEqual('string', typeof data);
assert.strictEqual(typeof data, 'string');

if (state === 1) {
assert.strictEqual('HTTP/1.1 101', data.substr(0, 12));
assert.strictEqual('WjN}|M(6', request_upgradeHead.toString('utf8'));
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 101');
assert.strictEqual(request_upgradeHead.toString('utf8'), 'WjN}|M(6');
conn.write('test', 'utf8');
} else if (state === 2) {
assert.strictEqual('test', data);
assert.strictEqual(data, 'test');
conn.write('kill', 'utf8');
}
});

conn.on('end', function() {
assert.strictEqual(2, state);
assert.strictEqual(state, 2);
conn.end();
server.removeAllListeners('upgrade');
test_upgrade_no_listener();
Expand Down Expand Up @@ -156,8 +156,8 @@ function test_standard_http() {
});

conn.once('data', function(data) {
assert.strictEqual('string', typeof data);
assert.strictEqual('HTTP/1.1 200', data.substr(0, 12));
assert.strictEqual(typeof data, 'string');
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 200');
conn.end();
});

Expand All @@ -179,6 +179,6 @@ server.listen(0, function() {
Fin.
-----------------------------------------------*/
process.on('exit', function() {
assert.strictEqual(3, requests_recv);
assert.strictEqual(3, requests_sent);
assert.strictEqual(requests_recv, 3);
assert.strictEqual(requests_sent, 3);
});