Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix parameters in test-repl.js #23609

Closed
wants to merge 1 commit into from
Closed

test: fix parameters in test-repl.js #23609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix parameters in test-repl.js 
fixed order of parameters in assert.strictEqual() assertion functions,
first argument provided was the expected value and the second value
was the actual value.

this is backwards from the documentation for assertions like
assert.strictEqual() where the first value being tested and the second
value is the expected value
  • Loading branch information
@binaryme
binaryme committed Oct 12, 2018
commit 771ce87d4d665cb2a940df7b854eb001a8f3ef02
8 changes: 4 additions & 4 deletions test/parallel/test-repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,8 +784,8 @@ function startTCPRepl() {
client.setEncoding('utf8');

client.on('connect', common.mustCall(() => {
assert.strictEqual(true, client.readable);
assert.strictEqual(true, client.writable);
assert.strictEqual(client.readable, true);
assert.strictEqual(client.writable, true);

resolveSocket(client);
}));
Expand Down Expand Up @@ -827,8 +827,8 @@ function startUnixRepl() {
client.setEncoding('utf8');

client.on('connect', common.mustCall(() => {
assert.strictEqual(true, client.readable);
assert.strictEqual(true, client.writable);
assert.strictEqual(client.readable, true);
assert.strictEqual(client.writable, true);

resolveSocket(client);
}));
Expand Down