test: error when empty buffer is passed to fs.read() #23141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Sep 28, 2018
BridgeAR
approved these changes
Sep 28, 2018
lpinca
approved these changes
Sep 28, 2018
jasnell
approved these changes
Sep 28, 2018
Added tests to occur error when empty buffer is passed to fs.read() to increase coverage.
shisama
force-pushed
the
test-fs-read-empty-buffer
branch
from
64168b8 to
3bf28b1
Compare
Contributor
Member
addaleax
added
the
author ready
Contributor
Author
Contributor
|
Resume again: https://ci.nodejs.org/job/node-test-commit-linux/22022/ ✔️ |
Contributor
|
Landed in 097896b. |
danbev
pushed a commit
that referenced
this pull request
Oct 3, 2018
Added tests to occur error when empty buffer is passed to fs.read() to increase coverage. PR-URL: #23141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Added tests to occur error when empty buffer is passed to fs.read() to increase coverage. PR-URL: #23141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to occur error when empty buffer is passed to
fs.read()to increase coverage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes