Skip to content

tools: fix cpplint --quiet option #23075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

tools: fix cpplint --quiet option #23075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03eb253
tools: fix cpplint --quiet option
danbev Sep 25, 2018
f9f9610
build: add --quiet to lint-cpp
danbev Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,7 @@ lint-cpp: tools/.cpplintstamp

tools/.cpplintstamp: $(LINT_CPP_FILES)
@echo "Running C++ linter..."
@$(PYTHON) tools/cpplint.py $?
@$(PYTHON) tools/cpplint.py --quiet $?
@$(PYTHON) tools/check-imports.py
@touch $@

Expand Down
5 changes: 2 additions & 3 deletions tools/cpplint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6429,11 +6429,10 @@ def ParseArguments(args):
except ValueError:
PrintUsage('Extensions must be comma seperated list.')
elif opt == '--recursive':
PrintUsage('Extensions must be comma separated list.')
elif opt == '--logfile':
recursive = True
elif opt == '--quiet':
elif opt == '--logfile':
logger.addHandler(logging.FileHandler(val, mode='wb'))
elif opt == '--quiet':
global _quiet
_quiet = True

Expand Down