Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add digitalinfinity to collaborators #22984

Closed
wants to merge 1 commit into from
Closed

doc: add digitalinfinity to collaborators #22984

wants to merge 1 commit into from

Conversation

digitalinfinity
Copy link
Contributor

Checklist

@nodejs-github-bot
Copy link
Collaborator

@digitalinfinity build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/952/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 20, 2018
@digitalinfinity digitalinfinity added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 20, 2018
@digitalinfinity
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17348/

@Trott
Copy link
Member

Trott commented Sep 20, 2018

👍 this comment for fast-track approval. Thanks!

@digitalinfinity
Copy link
Contributor Author

Landed in 734fa44

@digitalinfinity digitalinfinity deleted the collab_update branch September 20, 2018 23:47
digitalinfinity added a commit that referenced this pull request Sep 20, 2018
@digitalinfinity
doc: add digitalinfinity to collaborators
734fa44 
PR-URL: #22984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 21, 2018
@digitalinfinity @targos
doc: add digitalinfinity to collaborators
ef5d90d 
PR-URL: #22984
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@richardlau richardlau mentioned this pull request Sep 21, 2018
Closed
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@digitalinfinity @nodejs-github-bot @Trott @cjihrig