Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update maintaining V8 guide #22913

Closed
wants to merge 1 commit into from
Closed

doc: update maintaining V8 guide #22913

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 17, 2018

Replace references to the outdated update-v8 tool to its replacement
in node-core-utils

@targos
doc: update maintaining V8 guide
6d837ec 
Replace references to the outdated `update-v8` tool to its replacement
in `node-core-utils`
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/913/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 17, 2018
@danbev
Copy link
Contributor

danbev commented Sep 21, 2018

Landed in 408e8ce.

@danbev danbev closed this Sep 21, 2018
danbev pushed a commit that referenced this pull request Sep 21, 2018
@targos @danbev
doc: update maintaining V8 guide
408e8ce 
Replace references to the outdated `update-v8` tool to its replacement
in `node-core-utils`

PR-URL: #22913
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Sep 21, 2018
@targos
doc: update maintaining V8 guide
b0e86ea 
Replace references to the outdated `update-v8` tool to its replacement
in `node-core-utils`

PR-URL: #22913
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@targos targos deleted the doc-git-node-v8 branch October 17, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @nodejs-github-bot @danbev @jasnell @thefourtheye @lpinca @cjihrig @joyeecheung @richardlau @starkwang