Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: deprecate digest == null in PBKDF2 #22861

Closed
wants to merge 1 commit into from
Closed

crypto: deprecate digest == null in PBKDF2 #22861

wants to merge 1 commit into from

Commits on Sep 18, 2018

  1. crypto: deprecate digest == null in PBKDF2 

    I assume that permitting digest === null was unintentional when
digest === undefined was deprecated since their behavior was
equivalent. The sha1 default for digest === null has somehow made it
through refactoring of the PBKDF2 module multiple times, even though
digest === undefined has been EOL for some time now.

This change deprecates setting digest to null so we can fix the
behavior in Node.js 12 or so.
    @tniessen
    tniessen committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    6bcfb6f View commit details
    Browse the repository at this point in the history