Skip to content

test: fix flaky async-hooks/test-callback-error #22655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test: fix flaky async-hooks/test-callback-error #22655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efd776f
test: fix flaky async-hooks/test-callback-error
addaleax Sep 2, 2018
5d66adb
Revert "test: mark async-hooks/test-callback-error as flaky"
addaleax Sep 2, 2018
45d8600
fixup! test: fix flaky async-hooks/test-callback-error
addaleax Sep 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/async-hooks/async-hooks.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ test-statwatcher: PASS,FLAKY
[$system==linux]
# https://github.com/nodejs/node/issues/21425
test-statwatcher: PASS,FLAKY
# https://github.com/nodejs/node/issues/15985
test-callback-error: PASS,FLAKY

[$system==macos]

Expand Down
12 changes: 0 additions & 12 deletions test/async-hooks/test-callback-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ assert.ok(!arg);
{
console.log('start case 3');
console.time('end case 3');
// Timeout is set because this case is known to be problematic, so stderr is
// logged for further analysis.
// Ref: https://github.com/nodejs/node/issues/13527
// Ref: https://github.com/nodejs/node/pull/13559
const opts = {
execArgv: ['--abort-on-uncaught-exception'],
silent: true
Expand All @@ -78,15 +74,7 @@ assert.ok(!arg);
stderr += data;
});

const tO = setTimeout(() => {
console.log(stderr);
child.kill('SIGKILL');
process.exit(1);
}, 15 * 1000);
tO.unref();

child.on('close', (code, signal) => {
clearTimeout(tO);
if (common.isWindows) {
assert.strictEqual(code, 134);
assert.strictEqual(signal, null);
Expand Down