[v10.x] deps: sync V8 embedder string with master branch #22573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid conflicts while cherry-picking future V8 backports, increment the embedder string by one so it has the same value as in the master branch. The value was off by one because of an ABI-breaking backport that could not be taken in v10.x. Refs: nodejs#22106
nodejs-github-bot
added
build
addaleax
approved these changes
Aug 28, 2018
|
/cc @nodejs/v8-update |
refack
approved these changes
Aug 29, 2018
targos
added a commit
that referenced
this pull request
Aug 30, 2018
To avoid conflicts while cherry-picking future V8 backports, increment the embedder string by one so it has the same value as in the master branch. The value was off by one because of an ABI-breaking backport that could not be taken in v10.x. Refs: #22106 PR-URL: #22573 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in ea72368 |
targos
added a commit
that referenced
this pull request
Sep 3, 2018
To avoid conflicts while cherry-picking future V8 backports, increment the embedder string by one so it has the same value as in the master branch. The value was off by one because of an ABI-breaking backport that could not be taken in v10.x. Refs: #22106 PR-URL: #22573 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
added a commit
that referenced
this pull request
Sep 6, 2018
To avoid conflicts while cherry-picking future V8 backports, increment the embedder string by one so it has the same value as in the master branch. The value was off by one because of an ABI-breaking backport that could not be taken in v10.x. Refs: #22106 PR-URL: #22573 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid conflicts while cherry-picking future V8 backports, increment
the embedder string by one so it has the same value as in the master
branch. The value was off by one because of an ABI-breaking backport
that could not be taken in v10.x.
Refs: #22106