repl: improve error output #22436

BridgeAR · 2018-08-21T14:36:38Z

Currently extra properties on an error will be ignored, if thrown.
This information will from now on be visible.
In case someone threw a non error object it would have resulted in
[object Object]. Instead, the full object will now be visible.
Some cases were not detected properly as error before and "Thrown: "
was visible before. That is now fixed.
Refactor ERR_SCRIPT_EXECUTION_INTERRUPTED stack handling.
Error objects contained the domain properties due to the internal
handling. Those are now removed as they do not provide a benefit for
the user.

Refs: #20253

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

1) Currently extra properties on an error will be ignored, if thrown. This information will from now on be visible. 2) In case someone threw a non error object it would have resulted in `[object Object]`. Instead, the full object will now be visible. 3) Some cases were not detected properly as error before and "Thrown: " was visible before. That is now fixed.

The stack was removed later on instead of never being attached in the first place.

nodejs-github-bot · 2018-08-21T14:36:41Z

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/612/pipeline

BridgeAR · 2018-08-21T15:21:23Z

@nodejs/repl PTAL

devsnek · 2018-08-21T15:25:02Z

how does someone know if an error was thrown or logged, if they aren't prefixed with Thrown

BridgeAR · 2018-08-21T15:32:44Z

@devsnek that's just how the repl worked so far. I see your point but I guess that's a discussion for a different PR?

jdalton · 2018-08-22T22:15:43Z

lib/repl.js

+
+      if (internalUtil.isError(e)) {
+        if (e.stack) {
+          if (e instanceof SyntaxError) {


The error could be a syntax error from another realm (so not instanceof SyntaxError). Since we've already confirmed it is an error object above with isError(e) we could just check that the name is SyntaxError.

BridgeAR · 2018-08-24T13:07:14Z

Comment addressed.

CI https://ci.nodejs.org/job/node-test-pull-request/16725/

PTAL

jdalton · 2018-08-24T14:32:32Z

lib/repl.js

+              Error.stackTraceLimit = 0;
+              const err = new ERR_SCRIPT_EXECUTION_INTERRUPTED();
+              Error.stackTraceLimit = tmp;
+              reject(err);


Since .stack creation is deferred until the .stack is accessed does toggling the Error.stackTraceLimit have the effect wanted here (making an empty stack)? It looks like stackTraceLimit is reset before the lazy .stack is generated.

The stack size is set on error creation time. Otherwise the test would fail as well.

Ah, good to know!

BridgeAR · 2018-08-26T18:43:51Z

~~Resumed build: https://ci.nodejs.org/job/node-test-commit/20923/~~
~~Rebuild: https://ci.nodejs.org/job/node-test-commit/20924/~~
New CI https://ci.nodejs.org/job/node-test-pull-request/16764/

1) Currently extra properties on an error will be ignored, if thrown. This information will from now on be visible. 2) In case someone threw a non error object it would have resulted in `[object Object]`. Instead, the full object will now be visible. 3) Some cases were not detected properly as error before and "Thrown: " was visible before. That is now fixed. PR-URL: nodejs#22436 Refs: nodejs#20253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

The stack was removed later on instead of never being attached in the first place. PR-URL: nodejs#22436 Refs: nodejs#20253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR · 2018-08-27T12:09:57Z

Landed in ccb303e, 2eef077 🎉

addaleax · 2018-08-27T22:54:21Z

@BridgeAR Can you backport to v10.x-staging? It applies cleanly but there’s a failing test.

targos · 2018-09-02T19:36:18Z

Ping

1) Currently extra properties on an error will be ignored, if thrown. This information will from now on be visible. 2) In case someone threw a non error object it would have resulted in `[object Object]`. Instead, the full object will now be visible. 3) Some cases were not detected properly as error before and "Thrown: " was visible before. That is now fixed. PR-URL: #22436 Refs: #20253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

The stack was removed later on instead of never being attached in the first place. PR-URL: #22436 Refs: #20253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

The REPL implementation would strip away the first and last character of a formatted error message if it ended with `]` (but with the obviously missing check for a starting `]`), leading to things like `Uncaught rror: foo[a` being printed for input like `Error: foo[a]`. Refs: nodejs#22436

The REPL implementation would strip away the first and last character of a formatted error message if it ended with `]` (but with the obviously missing check for a starting `]`), leading to things like `Uncaught rror: foo[a` being printed for input like `Error: foo[a]`. Refs: #22436 PR-URL: #38209 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BridgeAR added 2 commits August 21, 2018 16:23

repl: refactor ERR_SCRIPT_EXECUTION_INTERRUPTED stack handling

9709144

The stack was removed later on instead of never being attached in the first place.

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Aug 21, 2018

BridgeAR requested review from lance, addaleax, TimothyGu, jasnell and mcollina August 22, 2018 22:03

addaleax approved these changes Aug 22, 2018

View reviewed changes

jdalton reviewed Aug 22, 2018

View reviewed changes

jasnell approved these changes Aug 22, 2018

View reviewed changes

fixup: address comment

8102eb1

jdalton reviewed Aug 24, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2018

fixup: fix windows test

c347f7a

BridgeAR closed this Aug 27, 2018

addaleax added the backport-requested-v10.x label Aug 27, 2018

targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 28, 2018

targos mentioned this pull request Sep 5, 2018

[v10.x needs a backport] - repl: improve error output #22710

Closed

targos removed the backport-requested-v10.x label Sep 23, 2018

targos mentioned this pull request Oct 7, 2018

Release proposal: v10.12.0 #23313

Merged

BridgeAR deleted the better-repl-errors branch January 20, 2020 11:35

addaleax mentioned this pull request Apr 12, 2021

repl: fix error message printing #38209

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: improve error output #22436

repl: improve error output #22436

BridgeAR commented Aug 21, 2018 •

edited

Loading

nodejs-github-bot commented Aug 21, 2018

BridgeAR commented Aug 21, 2018

devsnek commented Aug 21, 2018

BridgeAR commented Aug 21, 2018

jdalton Aug 22, 2018

BridgeAR commented Aug 24, 2018

jdalton Aug 24, 2018

BridgeAR Aug 24, 2018

jdalton Aug 24, 2018

BridgeAR commented Aug 26, 2018 •

edited

Loading

BridgeAR commented Aug 27, 2018

addaleax commented Aug 27, 2018

targos commented Sep 2, 2018

repl: improve error output #22436

repl: improve error output #22436

Conversation

BridgeAR commented Aug 21, 2018 • edited Loading

Checklist

nodejs-github-bot commented Aug 21, 2018

BridgeAR commented Aug 21, 2018

devsnek commented Aug 21, 2018

BridgeAR commented Aug 21, 2018

jdalton Aug 22, 2018

Choose a reason for hiding this comment

BridgeAR commented Aug 24, 2018

jdalton Aug 24, 2018

Choose a reason for hiding this comment

BridgeAR Aug 24, 2018

Choose a reason for hiding this comment

jdalton Aug 24, 2018

Choose a reason for hiding this comment

BridgeAR commented Aug 26, 2018 • edited Loading

BridgeAR commented Aug 27, 2018

addaleax commented Aug 27, 2018

targos commented Sep 2, 2018

BridgeAR commented Aug 21, 2018 •

edited

Loading

BridgeAR commented Aug 26, 2018 •

edited

Loading