tools: enable no-extra-semi rule in the linter#2207
Closed
silverwind wants to merge 2 commits intonodejs:masterfrom
Closed
tools: enable no-extra-semi rule in the linter#2207silverwind wants to merge 2 commits intonodejs:masterfrom
silverwind wants to merge 2 commits intonodejs:masterfrom
Conversation
silverwind
force-pushed
the
lint-semicolons
branch
from
de35e9c to
d40b055
Compare
This rule ensures that no unnecessary semicolon after function
declarations is allowed, e.g. this will error:
function x() {
// code
};
See eslint/eslint#3075 regarding body-less loops.
silverwind
force-pushed
the
lint-semicolons
branch
from
d40b055 to
bd5980d
Compare
silverwind
changed the title
Contributor
Author
Contributor
Author
|
Decided to close this one in favor of #2205. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
no-extra-semirule was requested multiple times, so here it is:The big issue here were bodyless
whileandforloops. I took the time to refactor two cases inlibto hopefully be more readable. There were a few cases intestthat do things like call a function until it returns false, where I opted to just put an empty body with a comment. If these are too ugly, we can wait on eslint/eslint#3075 for a fix.cc: @targos