doc: update iojs.1 for man page#2204
doc: update iojs.1 for man page#2204yosuke-furukawa wants to merge 1 commit intonodejs:masterfrom yosuke-furukawa:fix/man_page
Conversation
doc/iojs.1
Outdated
|
@Trott Thanks. I will fix. these options are generated by v8... I will try to report or pull request to v8. |
|
@yosuke-furukawa I already did a CL about that a while ago. |
|
LGTM btw |
doc/iojs.1
Outdated
|
Had been meaning to do this. LGTM otherwise. |
|
Had been meaning to do this also. LGTM minus the comment |
|
@yosuke-furukawa LGTM :) |
doc/iojs.1
Outdated
There was a problem hiding this comment.
Listed twice with different default values.
There was a problem hiding this comment.
ooops, this is also v8 document mistake....
|
fixed! PTAL @thefourtheye |
There was a problem hiding this comment.
overapproximate weak closer or overapproximate weak closure?
|
@yosuke-furukawa Sorry, I couldn't complete the review the other day. I left two more comments now. PTAL. LGTM 👍 |
|
I wouldn't worry about reviewing the v8 options too much. They'll probably just be overwritten in the future anyways. |
|
Yes, I agree @Fishrock123 . I just output these options using https://github.com/v8/v8-git-mirror/blob/master/src/flag-definitions.h#L635-L636 |
|
LGTM @yosuke-furukawa I guess you can land it after an rebase. |
|
@silverwind Thank you! |
|
Looks like the |
|
I feel this man page should be generated automatically. I will close this and I will send another PR ASAP. |
I checked
man iojsbut some options are missing like (--trace-sync-io, --strong_mode).so I just updated
iojs.1.