-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: rename WorkerThreadMain to PlatformWorkerThread #21982
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
Jul 26, 2018
targos
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
trace_events
Issues and PRs related to V8, Node.js core, and userspace code trace events.
c++
Issues and PRs that require attention from people who are familiar with C++.
and removed
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
labels
Jul 26, 2018
addaleax
approved these changes
Jul 26, 2018
benjamingr
approved these changes
Jul 26, 2018
Windows fail is #21425 |
ofrobots
approved these changes
Jul 26, 2018
cjihrig
approved these changes
Jul 27, 2018
jasnell
approved these changes
Jul 27, 2018
BridgeAR
approved these changes
Jul 29, 2018
Rebuild Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19529/ |
Landed in 7639023 |
Forgot to push... Really landed in afc5636 |
targos
added a commit
that referenced
this pull request
Jul 29, 2018
Refs: #21079 (comment) PR-URL: #21982 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Depends on #21079 to land on |
blattersturm
pushed a commit
to citizenfx/node
that referenced
this pull request
Nov 3, 2018
Refs: nodejs#21079 (comment) PR-URL: nodejs#21982 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
added
the
v8 platform
Issues and PRs related to Node's v8::Platform implementation.
label
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
trace_events
Issues and PRs related to V8, Node.js core, and userspace code trace events.
v8 platform
Issues and PRs related to Node's v8::Platform implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #21079 (comment)
/cc @nodejs/trace-events @addaleax
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes