Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add cjihrig pronouns #21901

Closed
wants to merge 1 commit into from
Closed

doc: add cjihrig pronouns #21901

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 20, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/321/pipeline

@Trott Trott added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jul 20, 2018
@Trott
Copy link
Member

Trott commented Jul 20, 2018

Put a 👍 on this comment to fast-track.

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 20, 2018
@cjihrig @Trott
doc: add cjihrig pronouns
cb754f5 
PR-URL: nodejs#21901
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@Trott
Copy link
Member

Trott commented Jul 20, 2018

Landed in cb754f5

@Trott Trott closed this Jul 20, 2018
@cjihrig cjihrig deleted the pronouns branch July 20, 2018 12:20
targos pushed a commit that referenced this pull request Jul 20, 2018
@cjihrig @targos
doc: add cjihrig pronouns
af1530e 
PR-URL: #21901
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@hiroppy hiroppy hiroppy approved these changes

@maclover7 maclover7 maclover7 approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @Trott @apapirovski @jasnell @maclover7 @hiroppy @devsnek