test,doc: address http2 connection abort/network error handling #21861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
doc
Trott
reviewed
Jul 17, 2018
doc/api/http2.md
Outdated
| stream.end('<h1>Hello World</h1>'); | ||
| }); | ||
|
|
||
| server.listen(80); | ||
| ``` | ||
|
|
||
| Even though HTTP/2 streams and network sockets are not in a 1:1 correspondence, | ||
| a network error will destroy each individual streams and must be handled on the |
jasnell
approved these changes
Jul 18, 2018
|
@nodejs/http2 |
doc/api/http2.md
Outdated
| @@ -271,12 +271,17 @@ server.on('stream', (stream, headers) => { | |||
| 'content-type': 'text/html', | |||
| ':status': 200 | |||
| }); | |||
| stream.on('error', (error) => console.log(error)); | |||
There was a problem hiding this comment.
console.log -> console.error?
There was a problem hiding this comment.
Or maybe just:
stream.on('error', console.error);There was a problem hiding this comment.
👍 Switched to the first suggestion – I’d prefer to give a user-defined function here, since that is a bit closer to what one would actually do in real-world code
trivikr
approved these changes
Jul 18, 2018
addaleax
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/15930/ (edit: ✔️) |
2 tasks
trivikr
approved these changes
Jul 18, 2018
lpinca
approved these changes
Jul 19, 2018
| @@ -271,12 +271,17 @@ server.on('stream', (stream, headers) => { | |||
| 'content-type': 'text/html', | |||
| ':status': 200 | |||
| }); | |||
| stream.on('error', (error) => console.error(error)); | |||
There was a problem hiding this comment.
Nit: how about passing console.error directly? It's already bound. If this is the prevalent usage in the docs, ignore this comment.
There was a problem hiding this comment.
JungMinu
approved these changes
Jul 21, 2018
Merged
This was referenced Aug 1, 2018
This was referenced Aug 1, 2018
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Aug 23, 2018
Fixes: nodejs#21836 PR-URL: nodejs#21861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
4 tasks
2 tasks
This was referenced Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes