repl: removing the buggy trimWhitespace function #2185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefourtheye
force-pushed
the
repl-regex-fix
branch
from
d57bad0 to
800a6e3
Compare
|
Why won't |
Contributor
Author
|
@alexlamsl True, but the other PR I submitted has needs to trim either the start or the end of the string. So I thought this will be consistent. |
Contributor
|
LGTM, thought I'd also prefer to use standard |
Contributor
@silverwind maybe you could also just review #2163? I'd prefer it landed. |
As it is, the trimWhitespace function will not remove the white sapce characters at the end of the string, as the greedy capturing group .+ captures everything till end of the string, leaving \s* with nothing. This patch removes the function and uses a proper RegEx which will match all the whitespace characters at the beginning and ending of the string and replaces the matched whitespace characters with empty string
thefourtheye
force-pushed
the
repl-regex-fix
branch
from
800a6e3 to
cde9a65
Compare
Contributor
Author
|
@silverwind @alexlamsl PTAL. Working on #2163's review comments. |
Contributor
|
LGTM 👍 |
Contributor
|
Closing in favor of #2163 since it's pretty well reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is, the trimWhitespace function will not remove the white sapce
characters at the end of the string, as the greedy capturing group .+
captures everything till end of the string, leaving \s* with nothing.
This patch removes the function and uses a proper RegEx which will
match all the whitespace characters at the beginning and ending of the
string and replaces the matched whitespace characters with empty string.
This is a floating fix till #2163 lands
cc @chrisdickinson