Skip to content

src: avoid unnecessarily formatting a warning #21832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: avoid unnecessarily formatting a warning #21832

wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jul 16, 2018

ProcessEmitWarning should already format the message, I think there is no need to call snprintf here.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@tniessen
src: avoid unnecessarily formatting a warning
a05ad54 
ProcessEmitWarning will already format the message, there is no
need to call snprintf here.
@tniessen tniessen requested a review from jasnell July 16, 2018 13:44
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 16, 2018

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/283/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Jul 16, 2018
@tniessen
Copy link
Member Author

tniessen commented Jul 17, 2018

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15904/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 17, 2018
tniessen added a commit that referenced this pull request Jul 18, 2018
@tniessen
src: avoid unnecessarily formatting a warning
7b6e2fc 
ProcessEmitWarning will already format the message, there is no
need to call snprintf here.

PR-URL: #21832
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen
Copy link
Member Author

tniessen commented Jul 18, 2018

Landed in 7b6e2fc.

@tniessen tniessen closed this Jul 18, 2018
targos pushed a commit that referenced this pull request Jul 19, 2018
@tniessen @targos
src: avoid unnecessarily formatting a warning
c45623a 
ProcessEmitWarning will already format the message, there is no
need to call snprintf here.

PR-URL: #21832
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+3 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tniessen @nodejs-github-bot @apapirovski @jasnell @addaleax @lpinca @TimothyGu @cjihrig @devsnek