Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove defunct timer_wrap file #21777

Closed
wants to merge 1 commit into from

Commits on Jul 14, 2018

  1. src: remove defunct timer_wrap file

    Unused since the excellent refactoring in 2930bd1,
    which also removed `src/timer_wrap.cc` from `node.gyp`. If you try and
    get at the binding on a v11.0-pre build, you'll get an error, since the
    file is no longer in the GYP build.
    
    ```
    Jonathans-MBP:node jon$ ./node -v
    v11.0.0-pre
    Jonathans-MBP:node jon$ ./node -e "process.binding('timer_wrap')"
    internal/bootstrap/loaders.js:81
            mod = bindingObj[module] = getBinding(module);
                                       ^
    
    Error: No such module: timer_wrap
        at process.binding (internal/bootstrap/loaders.js:81:36)
        at [eval]:1:9
        at Script.runInThisContext (vm.js:89:20)
        at Object.runInThisContext (vm.js:286:38)
        at Object.<anonymous> ([eval]-wrapper:6:22)
        at Module._compile (internal/modules/cjs/loader.js:689:30)
        at evalScript (internal/bootstrap/node.js:562:27)
        at startup (internal/bootstrap/node.js:248:9)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3)
    ```
    
    Refs: nodejs#20894
    maclover7 committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    8658963 View commit details
    Browse the repository at this point in the history