Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram: remove unnecessary fd property from Socket #21684

Closed
wants to merge 1 commit into from
Closed

dgram: remove unnecessary fd property from Socket #21684

wants to merge 1 commit into from

Commits on Aug 10, 2018

  1. dgram: remove unnecessary fd property from Socket 

    It seems the property socket.fd is used long before for the
compatibility reason but it's not used anymore. It's also
not documented in docs so that it's not a public api/property.
Keep the property also make the code a bit confusing as
socket._handle.fd is the actual property representing fd.
    @oyyd
    oyyd committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    4fa3fbd View commit details
    Browse the repository at this point in the history