errors: fix ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK #21493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
added
the
errors
nodejs-github-bot
added
the
errors
ChALkeR
force-pushed
the
doc-errcodes-remove-unused2
branch
from
bd6bb89
to
1a1b056
Compare
4 tasks
ChALkeR
force-pushed
the
doc-errcodes-remove-unused2
branch
2 times, most recently
from
bbcb61d
to
1fcf5e1
Compare
ChALkeR
added
the
esm
ChALkeR
requested review from
bmeck,
devsnek,
vsemozhetbyt,
BridgeAR and
ronkorving
devsnek
approved these changes
Jun 23, 2018
ChALkeR
added
the
author ready
This was referenced Jun 24, 2018
trivikr
approved these changes
Jun 24, 2018
vsemozhetbyt
approved these changes
Jun 24, 2018
3 tasks
TimothyGu
approved these changes
Jun 24, 2018
benjamingr
approved these changes
Jun 24, 2018
jasnell
approved these changes
Jun 24, 2018
ronkorving
approved these changes
Jun 25, 2018
lpinca
approved these changes
Jun 25, 2018
|
Ping @ChALkeR there is a small conflict. |
|
@targos, sorry, I am not feeling well and have only my phone right now. 🌡️ |
|
@ChALkeR sure. I hope you get better soon! I'm happy to take it over. Can I push to your branch? |
|
@targos, thanks! |
targos
force-pushed
the
doc-errcodes-remove-unused2
branch
from
1fcf5e1
to
d7fa6c2
Compare
This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the "INTST" vs "INST") in 921fb84 (PR nodejs#16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR nodejs#18857), as it appeared unused. This error code never worked or was documented under the mistyped name ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix. Refs: nodejs#21440 Refs: nodejs#21470 Refs: nodejs#16874 Refs: nodejs#18857
targos
force-pushed
the
doc-errcodes-remove-unused2
branch
from
d7fa6c2
to
75bf6a8
Compare
|
@targos Thanks for that again! |
|
No problem! |
|
Landed in 7bdc694 |
targos
pushed a commit
that referenced
this pull request
Jun 30, 2018
This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the "INTST" vs "INST") in 921fb84 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR #18857), as it appeared unused. This error code never worked or was documented under the mistyped name ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix. Refs: #21440 Refs: #21470 Refs: #16874 Refs: #18857 PR-URL: #21493 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Node.js v10.x is affected. |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2018
This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the "INTST" vs "INST") in 921fb84 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR #18857), as it appeared unused. This error code never worked or was documented under the mistyped name ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix. Refs: #21440 Refs: #21470 Refs: #16874 Refs: #18857 PR-URL: #21493 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores a broken and erroneously removed error, which was accidentially renamed to
ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK(notice theINTSTvsINST) in 921fb84 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR #18857), as it appeared unused.This error code never worked or was documented under the mistyped name
ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back toERR_MISSING_DYNAMIC_INSTANTIATE_HOOKis a semver-patch fix.Refs: #21440, #21470, #16874, #18857.
This is a part of the fixes hinted by #21470, which includes some tests for error codes usage and documentation and enforces a stricter format.
This is mostly a revert, and specific tests for esm loader actually emitting that error are not included here.
Generic tests for error codes are included in a separate PR: #21470.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes