Skip to content

test: ignore IRPStackSize bug on win32 #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: ignore IRPStackSize bug on win32 #2149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion test/parallel/test-debug-port-from-cmdline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,18 @@ child.stderr.on('data', function(data) {

child.on('message', function onChildMsg(message) {
if (message.msg === 'childready') {
process._debugProcess(child.pid);
try {
process._debugProcess(child.pid);
} catch (e) {
if (common.isWindows && (e.message ===
'Not enough storage is available to process this command.' ||
e.message === 'Access is denied.')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we write this as something like

if (common.isWindows &&
    (e.message === 'Not enough storage is available to process this command.' ||
     e.message === 'Access is denied.')) {

child.kill();
console.log('Encountered IRPStackSize bug on win32, ignoring test');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe comment linking to this issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to follow the convention

1..0 # Skipped: Encountered IRPStackSize bug on win32, ignoring test

while skipping tests, so that TAP Plugin can pick them.

return process.exit();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will process.exit return control back to this place? o.O I think its better to leave it with return.

}
throw e;
}
}
});

Expand Down