Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add build wg info to releases.md #21275

Closed
wants to merge 3 commits into from
Closed

doc: add build wg info to releases.md #21275

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5511b21
doc: add build wg info to releases.md
maclover7 Jun 12, 2018
73374c4
[squash] add "how"
maclover7 Jun 12, 2018
3506130
[squash] nits
maclover7 Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] nits
  • Loading branch information
@maclover7
maclover7 committed Jun 12, 2018
commit 3506130ef400b25e9d21d83ec7a5142e334e89e5
13 changes: 7 additions & 6 deletions doc/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,20 @@ Notes:

### 0. Pre-release steps

Before preparing a Node.js release, you must notify the Build Working Group at
least twenty-four hours in advance of the expected release. Coordinating with
Before preparing a Node.js release, the Build Working Group must be notified at
least one business day in advance of the expected release. Coordinating with
Build is essential to make sure that the CI works, release files are published,
and the release blog post is available on the project website.

Build can be contacted best by opening up an issue on the [issue tracker][],
Build can be contacted best by opening up an issue on the [Build issue tracker][],
and by posting in `#node-build` on [webchat.freenode.net][].

When preparing a security release, contact Build at least forty-eight hours in
When preparing a security release, contact Build at least two weekdays in
advance of the expected release. To ensure that the security patch(es) can be
properly tested, run a `node-test-pull-request` job against the `master` branch
of the `nodejs-private/node-private` repository a day or so before the
[CI lockdown procedure][] begins.
[CI lockdown procedure][] begins. This is to confirm that Jenkins can properly
access the private repository.

### 1. Cherry-picking from `master` and other branches

Expand Down Expand Up @@ -534,6 +535,6 @@ Close your release proposal PR and remove the proposal branch.
_In whatever form you do this..._

[CI lockdown procedure]: https://github.com/nodejs/build/blob/master/doc/jenkins-guide.md#restricting-access-for-security-releases
[issue tracker]: https://github.com/nodejs/build/issues/new
[Build issue tracker]: https://github.com/nodejs/build/issues/new
[nodejs.org release-post.js script]: https://github.com/nodejs/nodejs.org/blob/master/scripts/release-post.js
[webchat.freenode.net]: https://webchat.freenode.net/