Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: restore stdio on program exit" #21257

Closed
wants to merge 2 commits into from
Closed

Revert "src: restore stdio on program exit" #21257

wants to merge 2 commits into from

Commits on Jun 11, 2018

  1. Revert "src: restore stdio on program exit" 

    This reverts commit c2c9c0c.
It seems to be causing hangs when piping output to other processes.
    @evanlucas
    evanlucas committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    b56788d View commit details
    Browse the repository at this point in the history

  2. src: reset TTY mode before cleaning up resources 

    Otherwise, closing all handles associated with the main
event loop would also mean that `uv_tty_reset_mode()`
can’t function properly because the corresponding FDs have
already been closed.

Fixes: nodejs#21020
    @addaleax
    addaleax committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    02ed238 View commit details
    Browse the repository at this point in the history