Closed
Conversation
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: nodejs#1955 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing. PR-URL: nodejs#1965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Revewied-By: Evan Lucas <evanlucas@me.com>
PR-URL: nodejs#2004 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR-URL: nodejs/node-v0.x-archive#20109
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#1938 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
On upgrading openssl, all symlinks in pulic header files are replaced with nested include files. The issue was raised that installing them leads to lost its references to real header files. To avoid this, all public header files are copied into the `deps/openssl/openssl/include/openssl/` directory. As a result, we have duplicated header files under `deps/openssl/openssl/` but copied files are refereed in build as specified to include path in openssl.gyp. Fixes: nodejs#1975 PR-URL: nodejs#2016 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
to replace the full src download by node-gyp, using the proper format instead of the full source format PR-URL: nodejs#1975 Reviewed-By: William Blankenship <william.jblankenship@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Member
|
Rubber-stamp LGTM. |
Member
Author
|
Releases working, here's an RC: https://iojs.org/download/rc/v1.8.3-rc1/ built @ https://jenkins-iojs.nodesource.com/job/iojs+release/32/ |
Member
The smalloc deprecation commits would be good to back-port but should also pull in the commits around the NODE_DEPRECATED macro. Other candidates:
|
Contributor
|
LGTM, let's discuss other possible commits in another pr / issue, or maybe #1736 |
jbergstroem
added a commit
that referenced
this pull request
Jul 3, 2015
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: #1955 PORT-PR-URL: #2101 PORT-FROM: 1ec53c0 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
orangemocha
added a commit
that referenced
this pull request
Jul 3, 2015
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PORT-PR-URL: #2101 PORT-FROM: c0c0d73 PR-URL: nodejs/node-v0.x-archive#20109
shigeki
pushed a commit
that referenced
this pull request
Jul 3, 2015
On upgrading openssl, all symlinks in pulic header files are replaced with nested include files. The issue was raised that installing them leads to lost its references to real header files. To avoid this, all public header files are copied into the `deps/openssl/openssl/include/openssl/` directory. As a result, we have duplicated header files under `deps/openssl/openssl/` but copied files are refereed in build as specified to include path in openssl.gyp. Fixes: #1975 PR-URL: #2016 PORT-PR-URL: #2101 PORT-FROM: 1f371e3 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Contributor
|
Landed in a971255...d8f260d with port metadata, cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets v1.x working on the current Jenkins setup for tests: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/90/ and it should also be ready for releases.
Also, OpenSSL is upgraded on this branch, I remember @shigeki did that when he did master.
https://gist.github.com/rvagg/ad60803bc1885742780b I think has the commits currently not in v1.x that are in master if anyone would like to browse them and contribute to the @nodejs/lts discussion (not that 1.8.x is LTS, but it's a good proving ground) on the threshold for backports. I haven't looked in detail but I think the only things standing out at me are @indutny's fixes for stream_wrap etc.