doc: fix incorrect fs.readFileSync example output #20902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an incorrect example in the documentation for calling `fs.readFileSync` on a directory. The example was presumably copied from the documentation for `fs.readFile`, which has an error argument in its callback.
nodejs-github-bot
added
doc
addaleax
approved these changes
May 23, 2018
Contributor
Author
richardlau
approved these changes
May 23, 2018
jasnell
approved these changes
May 23, 2018
Member
|
+1 to fast-tracking after a green CI run |
Trott
approved these changes
May 23, 2018
Contributor
Author
|
CI again since the last run seemed to have a flaky test fail: |
cjihrig
approved these changes
May 23, 2018
trivikr
approved these changes
May 23, 2018
not-an-aardvark
added a commit
that referenced
this pull request
May 23, 2018
This fixes an incorrect example in the documentation for calling `fs.readFileSync` on a directory. The example was presumably copied from the documentation for `fs.readFile`, which has an error argument in its callback. PR-URL: #20902 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Contributor
Author
|
Landed in 5823938. (The last CI at https://ci.nodejs.org/job/node-test-pull-request-lite/745/ passed, but didn't update the status on this PR for some reason.) |
targos
pushed a commit
that referenced
this pull request
May 25, 2018
This fixes an incorrect example in the documentation for calling `fs.readFileSync` on a directory. The example was presumably copied from the documentation for `fs.readFile`, which has an error argument in its callback. PR-URL: #20902 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incorrect example in the documentation for calling
fs.readFileSyncon a directory. The example was presumably copied fromthe documentation for
fs.readFile, which has an error argument in itscallback.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes