Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: recompile when testing in CONTRIBUTING.md #2051

Closed
wants to merge 1 commit into from
Closed

doc: recompile when testing in CONTRIBUTING.md #2051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: recompile when testing in CONTRIBUTING.md 
Changes to core modules does not take effect before project gets
recompiled. Tip new contributors about this when describing how to
to run tests in contribution guide.

Removed `jslint` from first test command example as jslint are included
when running `make test`.

Fixed wrong path of example stream2-transform test.

PR-URL: #2051
  • Loading branch information
@phillipj
phillipj committed Jul 8, 2015
commit b8789d9b153be8a84f9c7dabd3ebc306017779c0
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ test/parallel/ directory. Look at other tests to see how they should be
structured (license boilerplate, common includes, etc.).

```text
$ make jslint test
$ ./configure && make -j8 test
```

Make sure the linter is happy and that all tests pass. Please, do not submit
Expand All @@ -142,9 +142,11 @@ $ python tools/test.py -v --mode=release parallel/test-stream2-transform
You can run tests directly with iojs:

```text
$ iojs ./test/parallel/test-streams2-transform.js
$ ./iojs ./test/parallel/test-stream2-transform.js
```

Remember to recompile with `make -j8` in between test runs if you change
core modules.

### Step 6: Push

Expand Down