Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove squash guideline from onboarding doc #20413

Closed
wants to merge 3 commits into from
Closed

doc: remove squash guideline from onboarding doc #20413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09cb507
doc: remove squash guideline from onboarding doc
Trott Apr 30, 2018
6fe0af1
doc: add squash guideline to pull-requests doc
Trott Apr 30, 2018
be7118e
squash! minor typographical fix
Trott Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions doc/guides/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,9 +599,10 @@ whether the failure was caused by the changes in the Pull Request.

### Commit Squashing

When the commits in your Pull Request land, they may be squashed
into one commit per logical change. Metadata will be added to the commit
message (including links to the Pull Request, links to relevant issues,
In most cases, do not squash commits that you add to your Pull Request during
the review process. When the commits in your Pull Request land, they may be
squashed into one commit per logical change. Metadata will be added to the
commit message (including links to the Pull Request, links to relevant issues,
and the names of the reviewers). The commit history of your Pull Request,
however, will stay intact on the Pull Request page.

Expand Down
1 change: 0 additions & 1 deletion doc/onboarding-extras.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,3 @@ to update from nodejs/node:
## Best practices

* When making PRs, spend time writing a thorough description.
* Usually only squash at the end of your work.