Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix todos #20319

Closed
wants to merge 5 commits into from
Closed

test: fix todos #20319

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46e2f50
test: remove obsolete TODOs
BridgeAR Apr 26, 2018
1f204dd
test: add fs.copyFile test
BridgeAR Apr 26, 2018
b6b64d9
fixup: remove another TODO
BridgeAR Apr 26, 2018
d09cb70
fixup: address test failure
BridgeAR Apr 26, 2018
83f63f1
fixup: add todo
BridgeAR Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: remove another TODO
  • Loading branch information
@BridgeAR
BridgeAR committed Apr 26, 2018
commit b6b64d96e19ab61f5b7aec95090a0630516c0c36
3 changes: 0 additions & 3 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,6 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
// http://a@b@c/ => user:a@b host:c
// http://a@b?@c => user:a host:b path:/?@c

// v0.12 TODO(isaacs): This is not quite how Chrome does things.
// Review our test case against browsers more comprehensively.

var hostEnd = -1;
var atSign = -1;
var nonHost = -1;
Expand Down