src: CancelTerminateExecution before throwing errors #20146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminating the execution of a script would create a pending exception, therefore we should cancel the termination *before* throwing a new exception, otherwise the attempt to create a custom error may fail.
nodejs-github-bot
added
c++
4 tasks
bnoordhuis
approved these changes
Apr 19, 2018
BridgeAR
added
the
author ready
cjihrig
approved these changes
Apr 19, 2018
@bnoordhuis Yeah, the CJS and ESM code could use some proper reuse there.. On a side note, maybe the ESM error would have been "Module evaluation timed out" or "Module evaluation was interrupted", but I doubt if that matters for end users |
addaleax
approved these changes
Apr 19, 2018
jasnell
approved these changes
Apr 19, 2018
|
Landed in 3eeb346, thanks |
joyeecheung
added a commit
that referenced
this pull request
Apr 22, 2018
Terminating the execution of a script would create a pending exception, therefore we should cancel the termination *before* throwing a new exception, otherwise the attempt to create a custom error may fail. PR-URL: #20146 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
Terminating the execution of a script would create a pending exception, therefore we should cancel the termination *before* throwing a new exception, otherwise the attempt to create a custom error may fail. PR-URL: #20146 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminating the execution of a script would create a pending
exception, therefore we should cancel the termination
before throwing a new exception, otherwise the attempt to
create a custom error may fail.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes